Conversation
|
@Jatin29yadav is attempting to deploy a commit to the OpenJS Foundation Team on Vercel. A member of the Team first needs to authorize it. |
6357918 to
a6d8c6b
Compare
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
evenstensberg
left a comment
There was a problem hiding this comment.
Nice work here. Could you revert the lockfile and version bumps?
I've accepted preview of this PR so we can see the visual of the pr.
|
Hey @eventensberg Governance section and subsections added under /src/content/contribute/governance/ Markdown lint issues (MD025, MD052) fixed Verified locally (yarn start) — all pages render correctly yarn.lock reverted and untouched CLA and lint checks have passed successfully Ready for re-review and merge |
|
@evenstensberg Can we write a script that fetch these files from webpack, because if we will need to change it it will require to make changes in both places, it is not good |
|
Thanks for the feedback @alexander-akait and @evenstensberg For this PR, I’ve focused on adding the initial Governance section and ensuring it’s integrated properly in /src/content/contribute/governance/. Everything now builds and renders correctly — ready for re-review whenever you’re available |
|
Let's try to implement this correct on the first pass. @Jatinyadav29 could you try to tackle this issue? It will make it better for you because then you can learn how the docs site really works. |
|
@evenstensberg |
|
Hey @alexander-akait @evenstensberg As discussed earlier in the governance PR thread — I’ve implemented the Governance content sync automation. This new script ( Highlights
Verified
This should make the Governance section fully maintainable and synced with the official |
evenstensberg
left a comment
There was a problem hiding this comment.
remove changes to lockfile and pkg.json, remove the md files because it is autogenerated.
|
Thanks for the feedback @evenstensberg |
| "rimraf": "^6.0.1", | ||
| "sass": "^1.79.5", | ||
| "sass-loader": "^16.0.4", | ||
| "sass": "^1.93.2", |
There was a problem hiding this comment.
dont commit the pkg.json or yarn lock unless you've added a command to "scripts".
There was a problem hiding this comment.
@evenstensberg
I tried reverting the changes in package.json and yarn.lock as suggested — I ran git checkout origin/main -- package.json yarn.lock,
but it seems the changes are still being shown in the PR.
Could you please guide me on what I might be missing or the correct way to fully revert them?
I want to make sure the PR stays clean and follows the project conventions.
There was a problem hiding this comment.
Ask copilot to help you rebase and remove file changes.
There was a problem hiding this comment.
@evenstensberg Done! I’ve rebased and pushed the clean branch — the PR now only includes the governance fetch script (fetch-governance.mjs). Thanks again for guiding me through this
f0f0c8e to
f1a0d6e
Compare
|
@Jatinyadav29 walk the through how to view the governance docs in your pr. |
|
If you look here, it just renderes the main gov docs, it doesnt include the fetches files https://webpack-js-e3xoiwwqb-openjs.vercel.app/concepts/governance/ |
|
Currently, the script ( In this PR preview, those fetched files aren’t rendered yet because the script isn’t triggered during the build process. |
|
So this means that you are missing fetching the governance repo on every build, right? Do the same procedure as |
|
Got it @evenstensberg! |
|
@evenstensberg , I’ve now added the |
|
The generated docs doesnt appear in the deploy |
|
ok let me fix that |
|
@evenstensberg. I’ve added the governance fetch step to the build workflow and verified it locally — |
evenstensberg
left a comment
There was a problem hiding this comment.
This changeset doesnt seem right. It has the commit from another pr too. Could you recreate the pr?
|
@evenstensberg, got it! |
|
Also, no need to use ai to communicate |
|
Sorry for that I will remember it for future. |
|
@evenstensberg I have created a new fresh PR please review it : gh pr checkout #7683 |

Summary
This pull request adds a "Governance" section to the documentation.
The content is adapted from the
[webpack/governance](https://github.com/webpack/governance)repository’s README file and converted into MDX format to align with the webpack.js.org documentation style and structure.Related Issue
Fixes [#7333](#7333)
Changes Introduced
Added new file:
src/content/contribute/governance.mdxConverted markdown to MDX format with frontmatter and internal link structure
Added YAML frontmatter:
Ensured compatibility with the docs build and navigation hierarchy
Preview
The new page introduces details about:
It provides transparency into webpack’s governance model, adapted from Node.js and ESLint governance frameworks.
Checklist
💡 Note: Since I’m still new to the webpack documentation setup, I took extra care to follow the contributing and writer’s guide. Please feel free to suggest any improvements or formatting changes.
